![]() ![]() Then does a character lookup and finally uses str.join() to build the sentence. It uses str.split() to initially split the words in the outer loop and then again to split the characters in the inner loop. This code uses two nested loops in the form of generator expressions. ''.join(MORSE_CODE for char in word.split())įor word in morse_code.strip().split(' ') I don't have access to the test cases, but I read the spec I think this would do the job: def decodeMorse(morse_code): This fairly simple change can greatly simplify the code needed inside the loop: def decodeMorse2(morse_code):įor index, di_dah in enumerate(morse_code.strip() + ' '): The str.strip() removes leading and trailing spaces, and the + ' ' at the end removes the need special casing after the loop. I would suggest changing your looping statement to: for index, di_dah in enumerate(morse_code.strip() + ' '):Įnumerate() is used to iterate over an object and give the index of of the current element. And then at the end will show a more Pythonic solution. I will start with showing some ways to improve your code. Looping over an index is just not needed that often. ![]() There is good chance you are not writing Pythonic code. In Python if you find yourself writing something like: while index < (length): # Add the final character to the clear text. # If the last character in the code is a space, assign a control value to "char" # If it is possible to encounter a space. # To cover the program encountering erroneous whitespace. # Build the character to be added to the clear text. I'd appreciate a critique of my code, such as best practices and the program logic itself. I wrote a program that works, but it was essentially done with ad hoc patches to cover the edge cases/exceptions the program initially didn't cover. This is mostly because otherwise the engine would simply ignore the tests, resulting in a "valid" solution.Īfter you complete this kata, you may try yourself at Decode the Morse code, advanced. In C#, tests will fail if the solution code throws an exception, please keep that in mind. Kotlin: MorseCode ?: "" or MorseCode.getOrDefault(".-", "")Īll the test strings would contain valid Morse code, so you may skip checking for errors and exceptions. Haskell: morseCodes ! ".-" (Codes are in a Map String String) The Morse code table is preloaded for you as a dictionary, feel free to use it:Ĭoffeescript/C++/Go/JavaScript/PHP/Python/Ruby/TypeScript: MORSE_CODEĬ#: MorseCode.Get(".-") (returns string) NOTE: For coding purposes you have to use ASCII characters. Your task is to implement a function that would take the morse code as input and return a decoded human-readable string.įor example: decodeMorse('. ![]() These special codes are treated as single special characters, and usually are transmitted as separate words. In addition to letters, digits and some punctuation, there are some special service codes, the most notorious of those is the international distress signal SOS (that was first issued by Titanic), that is coded as NOTE: Extra spaces before or after the code have no meaning and should be ignored. For example, the message HEY JUDE in Morse code is ![]() When the message is written in Morse code, a single space is used to separate the character codes and 3 spaces are used to separate words. The Morse code is case-insensitive, traditionally capital letters are used. The Morse code encodes every character as a sequence of "dots" and "dashes". While the Morse code is now mostly superceded by voice and digital data communication channels, it still has its use in some applications around the world. In this kata you have to write a simple Morse code decoder. After you solve this kata, you may move to the next one. This kata is part of a series on the Morse code. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |